Skip to content

Fix cl-transformation support of ng-if (#105) - #146

Merged
tocker merged 1 commit into
angular-1.xfrom
fix/ng-if-with-cl-transformation
Mar 12, 2019
Merged

tocker merged 1 commit into
angular-1.xfrom
fix/ng-if-with-cl-transformation

Conversation

@shedar

@shedar shedar commented Apr 10, 2018

Copy link
Copy Markdown

Replaces #110

@shedar
shedar requested a review from tocker April 10, 2018 22:05
@shedar

shedar commented Mar 12, 2019

Copy link
Copy Markdown
Author

@asisayag2 , which line are you referring to?
if https://github.com/cloudinary/cloudinary_angular/pull/146/files#diff-ca546277f613603532bbc9e5063c35bcR114 then it's done to be able to use simple watch, which only compares object references. Otherwise we'll need to watch collection content, which is more computationally expensive. And since modifications of transformations collection occurs less frequent than digest cycle - we do more work on adding transformation to do less work on change detection

@shedar
shedar force-pushed the fix/ng-if-with-cl-transformation branch from 1262a40 to 3dd6b62 Compare March 12, 2019 08:06
@tocker
tocker force-pushed the fix/ng-if-with-cl-transformation branch from 3dd6b62 to bbc8002 Compare March 12, 2019 13:36
@tocker
tocker merged commit 076f66f into angular-1.x Mar 12, 2019
@tocker
tocker deleted the fix/ng-if-with-cl-transformation branch March 12, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants